Add UidGenerator for stable UID generation across projects #1
Conversation
| @@ -18,6 +19,7 @@ | |||
| { | |||
| "kind": "Function", | |||
| "canonicalReference": "(ambientNameConflict:0)", | |||
| "uid": "api-extractor-scenarios/ambientNameConflict(Promise`1{void},api-extractor-scenarios/Promise`1{void})", | |||
There was a problem hiding this comment.
This UID refers to Promise, which is an ambient type picked up from the global context, which may be different for each invocation of the compiler. In this case it's probably the compiler's built-in type, but e.g. it could also be the React or Jest global variable. It seems imprecise for the UID to depend on definitions that are external to the API surface.
Also, I'd be curious to see what the output would be for a complex type like microsoft#1331 (comment), since people really do write code like that in practice.
And what the corresponding URL would be, given that URLs need to be case-insensitive.
It might be more efficient to chat about this offline, but as desirable as stable UIDs are, I'm really not convinced that it's appropriate for TypeScript.
|
Here's a commit with some more test cases: (I don't have permissions to push to your PR branch here.) |
|
See microsoft#1337 |
Fix a few issues with rush change when rush.json isn't in the repo root.
No description provided.